Fix GH-10647: Spoofchecker isSuspicious/areConfusable methods

error code's argument. Closes GH-10653.
php · Feb 21, 2023 · 0a466e7 · 0a466e7
1 parent da3ce60
commit 0a466e7
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 2 deletions.
diff --git a/NEWS b/NEWS
@@ -31,6 +31,10 @@ PHP                                                                        NEWS
   . Fixed bug GH-10315 (FPM unknown child alert not valid). (Jakub Zelenka)
   . Fixed bug GH-10385 (FPM successful config test early exit). (nielsdos)
 
+- Intl:
+  . Fixed bug GH-10647 (Spoolchecker isSuspicious/areConfusable methods
+    error code's argument always returning NULL0. (Nathan Freeman)
+
 - JSON:
   . Fixed JSON scanner and parser generation build.
     (Daniel Black, Jakub Zelenka)

diff --git a/ext/intl/spoofchecker/spoofchecker_main.c b/ext/intl/spoofchecker/spoofchecker_main.c
@@ -43,7 +43,8 @@ PHP_METHOD(Spoofchecker, isSuspicious)
 
 	if (error_code) {
 		zval_ptr_dtor(error_code);
-		ZVAL_LONG(error_code, ret);
+		ZVAL_LONG(Z_REFVAL_P(error_code), ret);
+		Z_TRY_ADDREF_P(error_code);
 	}
 	RETVAL_BOOL(ret != 0);
 }
@@ -76,7 +77,8 @@ PHP_METHOD(Spoofchecker, areConfusable)
 
 	if (error_code) {
 		zval_ptr_dtor(error_code);
-		ZVAL_LONG(error_code, ret);
+		ZVAL_LONG(Z_REFVAL_P(error_code), ret);
+		Z_TRY_ADDREF_P(error_code);
 	}
 	RETVAL_BOOL(ret != 0);
 }

diff --git a/ext/intl/tests/gh10647.phpt b/ext/intl/tests/gh10647.phpt
@@ -0,0 +1,24 @@
+--TEST--
+Bug GH-10647 (Spoofchecker::isSuspicious $errorCode always null)
+--SKIPIF--
+<?php
+if (!extension_loaded("intl")) die("skip intl extension not available");
+?>
+--FILE--
+<?php
+$error = 123;
+var_dump($error);
+
+$x = new Spoofchecker();
+var_dump($x->isSuspicious("\u{041F}aypal.com", $error));
+var_dump($error);
+
+var_dump($x->areConfusable('google.com', 'goog1e.com', $error));
+var_dump($error);
+?>
+--EXPECTF--
+int(123)
+bool(true)
+int(%d)
+bool(true)
+int(%d)