Skip to content

Commit

Permalink
Switch to tracing JIT by default
Browse files Browse the repository at this point in the history
  • Loading branch information
@dstogov
dstogov committed Jul 21, 2020
2 parents f7f5579 + 447a098 commit 0e1e991
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ext/opcache/jit/zend_jit.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
#define ZEND_JIT_REG_ALLOC_GLOBAL (1<<1) /* global linear scan register allocation */
#define ZEND_JIT_CPU_AVX (1<<2) /* use AVX instructions, if available */

#define ZEND_JIT_DEFAULT_OPTIONS "1205"
#define ZEND_JIT_DEFAULT_OPTIONS "1254"
#define ZEND_JIT_DEFAULT_BUFFER_SIZE "0"

#define ZEND_JIT_COUNTER_INIT 32531
Expand Down

4 comments on commit 0e1e991

@cmb69
Copy link
Contributor

@cmb69 cmb69 commented on 0e1e991 Jul 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstogov, it seems that the tests are stalling on AppVeyor as of this commit; it appears that AppVeyor times out always at this point. I cannot reproduce locally, though. Do you have any idea what might be wrong, or how to find out?

@dstogov
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmb69 I think, I found a problem. At least, a reason of some tests failures. There are 2 problems. The first is inability of embedding internal function address into JIT-ed code, because of ASLR. This aborts JIT compilation and after several failures triggers generation of escape code that performs deoptimization to VM. However, in some cases this code is incorrect.
I'm working on the fixes.
I may temporary revert this patch to not make troubles to others. Just ping me.

@cmb69
Copy link
Contributor

@cmb69 cmb69 commented on 0e1e991 Jul 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dstogov, for explaining and working on this. :)

I have now disabled tracing JIT for AppVeyor only (a986933); assuming this works out, I think it's better than to default to 1205 generally.

@dstogov
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmb69 it's fixed now. see #5883. I have reverted a986933

Please sign in to comment.