Skip to content

Commit

Permalink
Fixed bug #75616
Browse files Browse the repository at this point in the history
PDO can be built shared on Darwin nowadays. There used to be issues
relating to symbol references between dynamically loaded shared
objects.
  • Loading branch information
jdolecek-zz authored and nikic committed Dec 17, 2017
1 parent 200bf9b commit 11eed9f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 14 deletions.
4 changes: 4 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ PHP NEWS
(Nikita, Laruence)
. Fixed bug #75698 (Using @ crashes php7.2-fpm). (Nikita)

- PDO:
. Fixed bug #75616 (PDO extension doesn't allow to be built shared on Darwin).
(jdolecek)

- PDO MySQL:
. Fixed bug #75615 (PDO Mysql module can't be built as module). (jdolecek)

Expand Down
14 changes: 0 additions & 14 deletions ext/pdo/config.m4
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,6 @@ if test "$PHP_PDO" != "no"; then

PHP_PDO_PEAR_CHECK

if test "$ext_shared" = "yes" ; then
case $host_alias in
*darwin*)
AC_MSG_ERROR([
Due to the way that loadable modules work on OSX/Darwin, you need to
compile the PDO package statically into the PHP core.
Please follow the instructions at: http://netevil.org/node.php?nid=202
for more detail on this issue.
])
ext_shared=no
;;
esac
fi
PHP_NEW_EXTENSION(pdo, pdo.c pdo_dbh.c pdo_stmt.c pdo_sql_parser.c pdo_sqlstate.c, $ext_shared)
ifdef([PHP_ADD_EXTENSION_DEP],
[
Expand Down

0 comments on commit 11eed9f

Please sign in to comment.