Skip to content

Commit

Permalink
Skip some tests under --preload
Browse files Browse the repository at this point in the history
A genuine problem here is that we sometime get different class
casing due interaction with the ZSTR CE cache. Ignore these for
now.
  • Loading branch information
nikic committed Jul 30, 2021
1 parent 06cf4ff commit 1a370d3
Show file tree
Hide file tree
Showing 11 changed files with 40 additions and 4 deletions.
4 changes: 4 additions & 0 deletions Zend/tests/deprecation_to_exception_during_inheritance.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
--TEST--
Deprecation promoted to exception should result in fatal error during inheritance
--SKIPIF--
<?php
if (getenv('SKIP_PRELOAD')) die('skip Error handler not active during preloading');
?>
--FILE--
<?php

Expand Down
6 changes: 4 additions & 2 deletions Zend/tests/objects_008.phpt
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
--TEST--
method overloading with different method signature
--INI--
error_reporting=8191
--SKIPIF--
<?php
if (getenv('SKIP_PRELOAD')) die('xfail Difference in class name casing');
?>
--FILE--
<?php

Expand Down
4 changes: 4 additions & 0 deletions ext/phar/tests/front.phar.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ default_charset=UTF-8
opcache.validate_timestamps=1
--EXTENSIONS--
phar
--SKIPIF--
<?php
if (getenv('SKIP_PRELOAD')) die('skip Unknown failure');
?>
--ENV--
SCRIPT_NAME=/front.phar.php
REQUEST_URI=/front.phar.php/index.php
Expand Down
4 changes: 4 additions & 0 deletions ext/reflection/tests/ReflectionClass_isSubclassOf_error2.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
--TEST--
ReflectionClass::isSubclassOf() - fixed crash for unbound anonymous class
--SKIPIF--
<?php
if (getenv('SKIP_PRELOAD')) die('skip Anon class is linked during preloading');
?>
--FILE--
<?php
class X {
Expand Down
4 changes: 4 additions & 0 deletions ext/reflection/tests/bug76536.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
--TEST--
Bug #76536 (PHP crashes with core dump when throwing exception in error handler)
--SKIPIF--
<?php
if (getenv('SKIP_PRELOAD')) die('skip Error handler not available during preloading');
?>
--FILE--
<?php
class SomeConstants {const SOME_CONSTANT = "0foo" % 5; }
Expand Down
4 changes: 4 additions & 0 deletions ext/reflection/tests/intersection_types.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
--TEST--
Intersection types in reflection
--SKIPIF--
<?php
if (getenv('SKIP_PRELOAD')) die('xfail Difference in class name casing');
?>
--FILE--
<?php

Expand Down
6 changes: 4 additions & 2 deletions ext/reflection/tests/union_types.phpt
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
--TEST--
Union types in reflection
--INI--
error_reporting=E_ALL&~E_DEPRECATED
--SKIPIF--
<?php
if (getenv('SKIP_PRELOAD')) die('xfail Difference in class name casing');
?>
--FILE--
<?php

Expand Down
4 changes: 4 additions & 0 deletions ext/standard/tests/serialize/max_depth.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
--TEST--
Bug #78549: Stack overflow due to nested serialized input
--SKIPIF--
<?php
if (getenv('SKIP_PRELOAD')) die('skip Different order of deprecation messages');
?>
--FILE--
<?php

Expand Down
4 changes: 4 additions & 0 deletions ext/tidy/tests/026.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
tidy.clean_output test
--EXTENSIONS--
tidy
--SKIPIF--
<?php
if (getenv('SKIP_PRELOAD')) die('skip Output handler interferes');
?>
--INI--
tidy.clean_output=1
--FILE--
Expand Down
3 changes: 3 additions & 0 deletions ext/zend_test/tests/optimizer_register_pass.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ zend_test
if (getenv("SKIP_REPEAT")) {
die("skip pass registration does not need repeat");
}
if (getenv("SKIP_PRELOAD")) {
die("skip Not compatible with preload");
}
?>
--INI--
opcache.enable_cli=1
Expand Down
1 change: 1 addition & 0 deletions run-tests.php
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,7 @@ function main(): void
break;
case '--preload':
$preload = true;
$environment['SKIP_PRELOAD'] = 1;
break;
case '--file-cache-prime':
$file_cache = 'prime';
Expand Down

0 comments on commit 1a370d3

Please sign in to comment.