Skip to content

Commit

Permalink
Only check tracked files in verify-generated-files
Browse files Browse the repository at this point in the history
  • Loading branch information
@iluuu1994
iluuu1994 committed Apr 21, 2022
1 parent 36de002 commit 1dc6dba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/actions/verify-generated-files/action.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ runs:
scripts/dev/genfiles
Zend/zend_vm_gen.php
build/gen_stub.php -f
git add . -N && git diff --exit-code
git add . -Nu && git diff --exit-code

This comment has been minimized.

Sign in to view

Copy link
@mvorisek

mvorisek Apr 21, 2022

Contributor

-N was here by intention to check if build/tests clean all temporary files

This comment has been minimized.

Sign in to view

Copy link
@iluuu1994

iluuu1994 Apr 21, 2022

Author Member

I know, but PHP-8.1 build failed because some test didn't clean up a temp file, and it's not worthwhile. Only tracked files can be outdated.

This comment has been minimized.

Sign in to view

Copy link
@mvorisek

mvorisek Apr 21, 2022

Contributor

If we can fix one test for PHP-8.1 there should be high interest to keep this much stronger assertion in place.

This comment has been minimized.

Sign in to view

Copy link
@mvorisek

mvorisek Apr 22, 2022

Contributor

please see #8427 (comment) , PHP 8.1 branch needs 400c605 as fix instead of relaxing this check

0 comments on commit 1dc6dba

Please sign in to comment.