#73594 tests only check the extra params if dns_get_record is successful

php · Jul 10, 2017 · 2689917 · 2689917
1 parent 5cf54f6
commit 2689917
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/ext/standard/tests/network/bug73594.phpt b/ext/standard/tests/network/bug73594.phpt
@@ -19,8 +19,9 @@ if (empty($out)) die("skip local resolver does not return additional records");
 <?php
 $auth = array();
 $additional = array();
-dns_get_record('php.net', DNS_MX, $auth, $additional);
-var_dump(empty($additional));
+$res = dns_get_record('php.net', DNS_MX, $auth, $additional);
+// only check $additional if dns_get_record is successful
+var_dump(!empty($res) && empty($additional));
 ?>
 --EXPECT--
 bool(false)
diff --git a/ext/standard/tests/network/bug73594a.phpt b/ext/standard/tests/network/bug73594a.phpt
@@ -18,8 +18,9 @@ if (empty($out)) die("skip local resolver does not return authority records");
 --FILE--
 <?php
 $auth = array();
-dns_get_record('php.net', DNS_MX, $auth);
-var_dump(empty($auth));
+$res = dns_get_record('php.net', DNS_MX, $auth);
+// only check $auth if dns_get_record is successful
+var_dump(!empty($res) && empty($auth));
 ?>
 --EXPECT--
 bool(false)