Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[AArch64] Use crc32 instructions when available
The time goes from 0.838s down to 0.029s (a 28x speedup) on a Graviton A1 instance and the following benchmark: function simple_crc32() { $a = "foo"; for ($i = 0; $i < 10000; $i++) { crc32($a); $a .= "o".$i; } }
- Loading branch information
Showing
1 changed file
with
50 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a535a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this commit breaks aarch64 build
2a535a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to revert this minor optimization
Tracked on https://bugs.php.net/bug.php?id=78622
2a535a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@remicollet Could you please try this patch? https://gist.github.com/nikic/4b455d76d6cbb992700c326ae5a90acb
2a535a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikic build running https://koji.fedoraproject.org/koji/taskinfo?taskID=38002657
2a535a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikic
2a535a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@remicollet Here's another version: https://gist.github.com/nikic/51301da72853b3c3ad7659eba02232d1
If this doesn't work, let's revert this.
2a535a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikic see https://koji.fedoraproject.org/koji/taskinfo?taskID=38003042
Build still running, seems OK, only waiting for test suite results
2a535a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikic build done, everything is OK
Please apply your fix
Thanks a lot
2a535a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in d81eb77.