Skip to content

Commit

Permalink
Comment out ristretto255 scalar invert test
Browse files Browse the repository at this point in the history
This fails intermittently depending on which random scalar is
picked.
  • Loading branch information
nikic committed Aug 10, 2021
1 parent e5f53e1 commit 2addab1
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions ext/sodium/tests/crypto_core_ristretto255.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ $s3 = sodium_crypto_core_ristretto255_from_hash($ru);
var_dump(sodium_crypto_core_ristretto255_is_valid_point($s3));

// Modular inverse should be valid too (???)
$r_invert = sodium_crypto_core_ristretto255_scalar_invert($r);
var_dump(sodium_crypto_core_ristretto255_is_valid_point($r_invert));
//$r_invert = sodium_crypto_core_ristretto255_scalar_invert($r);
//var_dump(sodium_crypto_core_ristretto255_is_valid_point($r_invert));

$s_plus = sodium_crypto_core_ristretto255_add($s, $s0);
$s_minus = sodium_crypto_core_ristretto255_sub($s_plus, $s0);
Expand Down Expand Up @@ -130,5 +130,4 @@ string(64) "3066f82a1a747d45120d1740f14358531a8f04bbffe6a819f86dfe50f44a0a46"
bool(true)
Result is identity element
bool(true)
bool(false)
bool(true)

0 comments on commit 2addab1

Please sign in to comment.