Removed already implemented TODO comment

php · Jul 3, 2020 · 2ecc597 · 2ecc597
1 parent 62f05ac
commit 2ecc597
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/ext/opcache/jit/zend_jit_trace.c b/ext/opcache/jit/zend_jit_trace.c
@@ -3591,17 +3591,18 @@ static const void *zend_jit_trace(zend_jit_trace_rec *trace_buffer, uint32_t par
 								goto jit_failure;
 						    }
 							for (j = 0 ; j < op_array->last_var; j++) {
+								uint32_t info;
+								zend_uchar type;
+
 								if (opline->op1_type == IS_CV
 								 && EX_VAR_TO_NUM(opline->op1.var) == j
 								 && !(op1_info & MAY_BE_REF)
 								 && JIT_G(current_frame)
 								 && TRACE_FRAME_IS_RETURN_VALUE_USED(JIT_G(current_frame))) {
 									continue;
 								}
-								// TODO: get info from trace ???
-								uint32_t info = zend_ssa_cv_info(opline, op_array, op_array_ssa, j);
-								zend_uchar type = STACK_TYPE(stack, j);
-
+								info = zend_ssa_cv_info(opline, op_array, op_array_ssa, j);
+								type = STACK_TYPE(stack, j);
 								info = zend_jit_trace_type_to_info_ex(type, info);
 								if (info & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF)) {
 									if (!zend_jit_free_cv(&dasm_state, opline, op_array, info, j)) {