Skip to content

Commit

Permalink
Fix 3b0fecd and resulting test fail lob_012.phpt
Browse files Browse the repository at this point in the history
  • Loading branch information
@cjbj
cjbj committed Sep 9, 2020
1 parent 73c7fa2 commit 311fa34
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ext/oci8/oci8_interface.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -831,7 +831,7 @@ PHP_FUNCTION(oci_lob_export)
php_stream *stream;
ub4 lob_length;

if (zend_parse_method_parameters(ZEND_NUM_ARGS(), getThis(), "Os|l!l!", &z_descriptor, oci_lob_class_entry_ptr, &filename, &filename_len, &start, &length) == FAILURE) {
if (zend_parse_method_parameters(ZEND_NUM_ARGS(), getThis(), "Os|l!l!", &z_descriptor, oci_lob_class_entry_ptr, &filename, &filename_len, &start, &start_is_null, &length, &length_is_null) == FAILURE) {
RETURN_THROWS();
}

Expand Down

2 comments on commit 311fa34

@kocsismate
Copy link
Member

@kocsismate kocsismate commented on 311fa34 Sep 9, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, then I still managed to commit a critical error 😕 thanks for the follow-up!

@cjbj
Copy link
Contributor Author

@cjbj cjbj commented on 311fa34 Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem.

If you do ever want an Oracle DB, there is an 'always free' Oracle cloud service you can sign up for at https://www.oracle.com/cloud/free/

Please sign in to comment.