Validate that promoted readonly properties have a type

php · Jul 25, 2021 · 3babe95 · 3babe95
1 parent 8d25b62
commit 3babe95
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/Zend/tests/readonly_props/promotion_error1.phpt b/Zend/tests/readonly_props/promotion_error1.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Promoted readonly property must have type
+--FILE--
+<?php
+
+class Foo {
+    public function __construct(
+        public readonly $bar
+    ) {}
+}
+
+?>
+--EXPECTF--
+Fatal error: Readonly property Foo::$bar must have type in %s on line %d
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
@@ -6774,6 +6774,11 @@ void zend_compile_params(zend_ast *ast, zend_ast *return_type_ast, uint32_t fall
 			if (ZEND_TYPE_IS_SET(type)) {
 				ZVAL_UNDEF(&default_value);
 			} else {
+				if (property_flags & ZEND_ACC_READONLY) {
+					zend_error_noreturn(E_COMPILE_ERROR, "Readonly property %s::$%s must have type",
+						ZSTR_VAL(scope->name), ZSTR_VAL(name));
+				}
+
 				ZVAL_NULL(&default_value);
 			}