Skip to content

Commit

Permalink
Update PHP-Parser from 4.3.0 to 4.9.0
Browse files Browse the repository at this point in the history
PHP-Parser 4.3.0 failed to recognize that the `match` keyword could be
used as a class constant name.
4.9.0 also adds support for keywords in namespaced names.
See https://github.com/nikic/PHP-Parser/releases

So forcing regeneration of spl_iterators.stub.php failed.

PECL extensions using gen_stub.php would also be affected
by the same issue.

```
ext/spl/spl_iterators.stub.php
    public function __construct(Iterator $iterator, string $regex,
    int $mode = self::MATCH, int $flags = 0, int $preg_flags = 0) {}
```

Testing: I successfully regenerated stubs by setting forceRegeneration to true
and running `touch **/*.stub.php; make`.
The stubs did not change, as expected.

Closes GH-6036
  • Loading branch information
TysonAndre committed Aug 23, 2020
1 parent e6044d4 commit 4bba59d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/gen_stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ function initPhpParser() {
}

$isInitialized = true;
$version = "4.3.0";
$version = "4.9.0";
$phpParserDir = __DIR__ . "/PHP-Parser-$version";
if (!is_dir($phpParserDir)) {
installPhpParser($version, $phpParserDir);
Expand Down

0 comments on commit 4bba59d

Please sign in to comment.