Skip to content

Commit

Permalink
Make IntlCalendar::roll() return type tentative
Browse files Browse the repository at this point in the history
This method did not have a type in PHP 8.0 and is not final, so
the new return type should be tentative.
  • Loading branch information
nikic committed Sep 22, 2021
1 parent cffba94 commit 4fcca03
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions ext/intl/calendar/calendar.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ public function isWeekend(?float $timestamp = null): bool {}
/**
* @param int|bool $value
* @alias intlcal_roll
* @tentative-return-type
*/
public function roll(int $field, $value): bool {}

Expand Down
4 changes: 2 additions & 2 deletions ext/intl/calendar/calendar_arginfo.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 1f47fca82af35929e8cbcb9b2b9979c4c03f658c */
* Stub hash: 2265c2a4f478d6ccd576ce09a19a158df38a2bdb */

ZEND_BEGIN_ARG_INFO_EX(arginfo_class_IntlCalendar___construct, 0, 0, 0)
ZEND_END_ARG_INFO()
Expand Down Expand Up @@ -113,7 +113,7 @@ ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(arginfo_class_IntlCalendar_isW
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, timestamp, IS_DOUBLE, 1, "null")
ZEND_END_ARG_INFO()

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_IntlCalendar_roll, 0, 2, _IS_BOOL, 0)
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(arginfo_class_IntlCalendar_roll, 0, 2, _IS_BOOL, 0)
ZEND_ARG_TYPE_INFO(0, field, IS_LONG, 0)
ZEND_ARG_INFO(0, value)
ZEND_END_ARG_INFO()
Expand Down

0 comments on commit 4fcca03

Please sign in to comment.