Add missing error check on PEM_write_bio_CMS()

On failure, this function returns 0. 2 other callers of this function already check the return value, but this one was missed.
php · Mar 5, 2023 · 51ea4a6 · 51ea4a6
1 parent d2ef156
commit 51ea4a6
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -5991,7 +5991,11 @@ PHP_FUNCTION(openssl_cms_verify)
 			}
 
 			if (p7bout) {
-				PEM_write_bio_CMS(p7bout, cms);
+				if (PEM_write_bio_CMS(p7bout, cms) == 0) {
+					php_error_docref(NULL, E_WARNING, "Failed to write CMS to file");
+					php_openssl_store_errors();
+					RETVAL_FALSE;
+				}
 			}
 		}
 	} else {