Skip to content

Commit

Permalink
Reduce threshold further in ext/date/tests/bug73837.phpt
Browse files Browse the repository at this point in the history
The threshold in test case ext/date/tests/bug73837.phpt has been reduced
several times, from the original 990 to current 400. However, this case
still failed on my local test with Mac Mini machine(macOS on Apple
silicon). Here is the diff result:

```
  $ cat ext/date/tests/bug73837.diff
     int(%d)
  002+ microseconds do not differ enough (268)
  002- microseconds differ
```

Hence this patch reduces the threshold further.

Note that this patch should be backported to PHP 8.1 branch as well.

Closes GH-7567.
  • Loading branch information
shqking committed Oct 12, 2021
1 parent 1208fe9 commit 582e21f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ext/date/tests/bug73837.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ for ( $i = 0; $i < 1000; $i++ )

// For low-resolution clocks, we may construct many objects in the same tick.
var_dump($n = count( $collect ));
echo $n > 400 ? "microseconds differ\n" : "microseconds do not differ enough ($n)\n";
echo $n > 200 ? "microseconds differ\n" : "microseconds do not differ enough ($n)\n";
?>
--EXPECTF--
int(%d)
Expand Down

0 comments on commit 582e21f

Please sign in to comment.