Better fix bug #75540 Segfault with libzip 1.3.1

- only 1.3.1 is affected - fix use after free
php · Nov 20, 2017 · 702ef27 · 702ef27
1 parent 8832c46
commit 702ef27
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/ext/zip/php_zip.c b/ext/zip/php_zip.c
@@ -1513,9 +1513,10 @@ static ZIPARCHIVE_METHOD(close)
 	ze_obj = Z_ZIP_P(self);
 
 	if ((err = zip_close(intern))) {
+#if LIBZIP_VERSION_MAJOR == 1 && LIBZIP_VERSION_MINOR == 3 && LIBZIP_VERSION_MICRO == 1
+		php_error_docref(NULL, E_WARNING, "%s", "zip_close have failed");
+#else
 		php_error_docref(NULL, E_WARNING, "%s", zip_strerror(intern));
-#if LIBZIP_VERSION_MAJOR < 1 || (LIBZIP_VERSION_MAJOR == 1 && LIBZIP_VERSION_MINOR < 3) || (LIBZIP_VERSION_MAJOR == 1 && LIBZIP_VERSION_MINOR == 3 && LIBZIP_VERSION_MICRO < 1)
-		/* Fix memory leak in libzip < 1.3.1 */
 		zip_discard(intern);
 #endif
 	}