Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix GH-9316: $http_response_header is wrong for long status line
While the reason-phrase in a HTTP response status line is usually short, there is no actual limit specified by the RFCs. As such, we must not assume that the line fits into the buffer (which is currently 128 bytes large). Since there is no real need to present the complete status line, we simply read and discard the rest of a long line. Co-authored-by: Tim Düsterhus <timwolla@googlemail.com> Closes GH-9319.
- Loading branch information
Showing
3 changed files
with
45 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
--TEST-- | ||
Bug GH-9316 ($http_response_header is wrong for long status line) | ||
--SKIPIF-- | ||
<?php require 'server.inc'; http_server_skipif(); ?> | ||
--INI-- | ||
allow_url_fopen=1 | ||
--FILE-- | ||
<?php | ||
require 'server.inc'; | ||
|
||
$responses = array( | ||
"data://text/plain,HTTP/1.1 200 Some very long reason-phrase to test that this is properly handled by our code without adding a new header like Bad: Header\r\nGood: Header\r\n\r\nBody", | ||
"data://text/plain,HTTP/1.1 200 \r\nGood: Header\r\n\r\nBody", | ||
); | ||
|
||
['pid' => $pid, 'uri' => $uri] = http_server($responses, $output); | ||
|
||
for ($i = 0; $i < count($responses); ++$i) { | ||
$f = @fopen($uri, "r"); | ||
var_dump($http_response_header); | ||
fclose($f); | ||
} | ||
|
||
http_server_kill($pid); | ||
|
||
--EXPECT-- | ||
array(2) { | ||
[0]=> | ||
string(126) "HTTP/1.1 200 Some very long reason-phrase to test that this is properly handled by our code without adding a new header like " | ||
[1]=> | ||
string(12) "Good: Header" | ||
} | ||
array(2) { | ||
[0]=> | ||
string(13) "HTTP/1.1 200 " | ||
[1]=> | ||
string(12) "Good: Header" | ||
} |