Fixed memory leak (ext/hash/tests/mhash_001.phpt failure)

php · Aug 19, 2020 · 736c5dc · 736c5dc
1 parent 9883fec
commit 736c5dc
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/ext/hash/hash.c b/ext/hash/hash.c
@@ -1202,7 +1202,7 @@ PHP_FUNCTION(mhash)
 	if (algorithm >= 0 && algorithm < MHASH_NUM_ALGOS) {
 		struct mhash_bc_entry algorithm_lookup = mhash_to_hash[algorithm];
 		if (algorithm_lookup.hash_name) {
-			algo = zend_string_init(algorithm_lookup.hash_name, strlen(algorithm_lookup.hash_name), 1);
+			algo = zend_string_init(algorithm_lookup.hash_name, strlen(algorithm_lookup.hash_name), 0);
 		}
 	}
 
@@ -1211,6 +1211,10 @@ PHP_FUNCTION(mhash)
 	} else {
 		php_hash_do_hash(return_value, algo, data, data_len, 1, 0);
 	}
+
+	if (algo) {
+		zend_string_release(algo);
+	}
 }
 /* }}} */