- unify warning between win and unix and enable test

php · Sep 4, 2011 · 7e5d921 · 7e5d921
1 parent d1b156f
commit 7e5d921
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/ext/standard/dns_win32.c b/ext/standard/dns_win32.c
@@ -103,6 +103,11 @@ PHP_FUNCTION(dns_check_record)
 		return;
 	}
 
+	if (hostname_len == 0) {
+		php_error_docref(NULL TSRMLS_CC, E_WARNING, "Host cannot be empty");
+		RETURN_FALSE;
+	}
+
 	if (rectype) {
 		     if (!strcasecmp("A",     rectype)) type = DNS_TYPE_A;
 		else if (!strcasecmp("NS",    rectype)) type = DNS_TYPE_NS;

diff --git a/ext/standard/tests/network/bug41347.phpt b/ext/standard/tests/network/bug41347.phpt
@@ -1,11 +1,5 @@
 --TEST--
 dns_check_record() segfault with empty host
---SKIPIF--
-<?php
-if (substr(PHP_OS, 0, 3) == 'WIN') {
-    die('skip No windows support');
-}
-?>
 --FILE--
 <?php
 var_dump(dns_check_record(''));