Skip to content

Commit

Permalink
Mark tests as XFAIL on Windows
Browse files Browse the repository at this point in the history
These tests segfault with tracing JIT on Windows as of a recent
commit[1].  A link to a backtrace is available in a comment[2].  For
now, we mark these tests as XFAIL, to keep AppVeyor CI helpful.

[1] <817ae41>
[2] <817ae41#commitcomment-42227420>
  • Loading branch information
cmb69 committed Sep 13, 2020
1 parent 3854234 commit 873c087
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
5 changes: 5 additions & 0 deletions ext/session/tests/session_decode_basic.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
Test session_decode() function : basic functionality
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
die('xfail issues with JIT on Windows');
}
?>
--FILE--
<?php

Expand Down
5 changes: 5 additions & 0 deletions ext/session/tests/session_decode_basic_serialize.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
Test session_decode() function : basic functionality
--SKIPIF--
<?php include('skipif.inc'); ?>
<?php
if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
die('xfail issues with JIT on Windows');
}
?>
--FILE--
<?php

Expand Down

0 comments on commit 873c087

Please sign in to comment.