-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't leak header callback if headers already sent
We need to avoid storing it in the first place, as we don't really have a good place to release it later. If headers haven't been sent yet, send_headers will do this. sapi_deactive happens too late in the shutdown sequence and will result in leak reports.
- Loading branch information
Showing
2 changed files
with
14 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--TEST-- | ||
Call header_register_callback() after headers sent | ||
--FILE-- | ||
<?php | ||
echo "Send headers.\n"; | ||
header_register_callback(function() { echo "Too late";}); | ||
?> | ||
--EXPECT-- | ||
Send headers. |