Skip to content

Commit

Permalink
Sync JIT zend_check_string_offset()
Browse files Browse the repository at this point in the history
Return after zend_jit_illegal_string_offset() to avoid a redundant
warning during conversion.

This fixes some tests under PROFITABILITY_CHECKS=0.
  • Loading branch information
nikic committed Jul 21, 2021
1 parent 0fb1ccc commit a190c7f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ext/opcache/jit/zend_jit_helpers.c
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ static zend_never_inline zend_long zend_check_string_offset(zval *dim/*, int typ
return offset;
}
zend_jit_illegal_string_offset(dim);
break;
return 0;
}
case IS_UNDEF:
zend_jit_undefined_op_helper(EG(current_execute_data)->opline->op2.var);
Expand All @@ -705,7 +705,7 @@ static zend_never_inline zend_long zend_check_string_offset(zval *dim/*, int typ
goto try_again;
default:
zend_jit_illegal_string_offset(dim);
break;
return 0;
}

return zval_get_long_func(dim, /* is_strict */ false);
Expand Down

0 comments on commit a190c7f

Please sign in to comment.