Skip to content

Commit

Permalink
Skip arginfo test under msan
Browse files Browse the repository at this point in the history
Msan is missing interceptors for some functions that result in
false positives.
  • Loading branch information
nikic committed Oct 15, 2020
1 parent 682cc42 commit b270081
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
4 changes: 4 additions & 0 deletions Zend/tests/arginfo_zpp_mismatch.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
--TEST--
Test that there is no arginfo/zpp mismatch
--SKIPIF--
<?php
if (getenv('SKIP_MSAN')) die("skip msan misses interceptors for some functions");
?>
--FILE--
<?php

Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
parameters:
configurationName: DEBUG_ZTS_MSAN
configurationParameters: '--enable-debug --enable-zts'
runTestsParameters: --asan
runTestsParameters: --msan
timeoutInMinutes: 90
- template: azure/community_job.yml
parameters:
Expand Down
4 changes: 4 additions & 0 deletions run-tests.php
Original file line number Diff line number Diff line change
Expand Up @@ -608,10 +608,14 @@ function main(): void
$shuffle = true;
break;
case '--asan':
case '--msan':
$environment['USE_ZEND_ALLOC'] = 0;
$environment['USE_TRACKED_ALLOC'] = 1;
$environment['SKIP_ASAN'] = 1;
$environment['SKIP_PERF_SENSITIVE'] = 1;
if ($switch === '--msan') {
$environment['SKIP_MSAN'] = 1;
}

$lsanSuppressions = __DIR__ . '/azure/lsan-suppressions.txt';
if (file_exists($lsanSuppressions)) {
Expand Down

0 comments on commit b270081

Please sign in to comment.