Skip to content

Commit

Permalink
Fix maybe-uninitialized warning
Browse files Browse the repository at this point in the history
Some GCC versions don't like zend_try in loop. Avoid the issue
by pulling it out of the loop, we don't particularly care about
skipping further warnings if a bailout occurs, just that it
does not interrupt shutdown.

Closes GH-7380.
  • Loading branch information
nikic committed Aug 17, 2021
1 parent e45a063 commit b66168e
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions ext/imap/php_imap.c
Original file line number Diff line number Diff line change
Expand Up @@ -657,13 +657,13 @@ PHP_RSHUTDOWN_FUNCTION(imap)
if (IMAPG(imap_errorstack) != NIL) {
/* output any remaining errors at their original error level */
if (EG(error_reporting) & E_NOTICE) {
ecur = IMAPG(imap_errorstack);
while (ecur != NIL) {
zend_try {
zend_try {
ecur = IMAPG(imap_errorstack);
while (ecur != NIL) {
php_error_docref(NULL, E_NOTICE, "%s (errflg=%ld)", ecur->LTEXT, ecur->errflg);
} zend_end_try();
ecur = ecur->next;
}
ecur = ecur->next;
}
} zend_end_try();
}
mail_free_errorlist(&IMAPG(imap_errorstack));
IMAPG(imap_errorstack) = NIL;
Expand All @@ -672,13 +672,13 @@ PHP_RSHUTDOWN_FUNCTION(imap)
if (IMAPG(imap_alertstack) != NIL) {
/* output any remaining alerts at E_NOTICE level */
if (EG(error_reporting) & E_NOTICE) {
acur = IMAPG(imap_alertstack);
while (acur != NIL) {
zend_try {
zend_try {
acur = IMAPG(imap_alertstack);
while (acur != NIL) {
php_error_docref(NULL, E_NOTICE, "%s", acur->LTEXT);
} zend_end_try();
acur = acur->next;
}
acur = acur->next;
}
} zend_end_try();
}
mail_free_stringlist(&IMAPG(imap_alertstack));
IMAPG(imap_alertstack) = NIL;
Expand Down

0 comments on commit b66168e

Please sign in to comment.