Fix: Gracefully handle empty user input in run-tests.php

Berbe · nikic · commit bfeb2f6abc35 · 2020-08-24T11:46:01.000+02:00
Closes GH-6016.
diff --git a/run-tests.php b/run-tests.php
@@ -942,7 +942,7 @@ function save_or_mail_results(): void
         flush();
 
         $user_input = fgets($fp, 10);
-        $just_save_results = (strtolower($user_input[0]) == 's');
+        $just_save_results = (!empty($user_input) && strtolower($user_input[0]) === 's');
     }
 
     if ($just_save_results || !getenv('NO_INTERACTION') || TRAVIS_CI) {

Original file line number	Diff line number	Diff line change
`@@ -942,7 +942,7 @@ function save_or_mail_results(): void`
`942`	`942`	`flush();`
`943`	`943`
`944`	`944`	`$user_input = fgets($fp, 10);`
`945`		`- $just_save_results = (strtolower($user_input[0]) == 's');`
	`945`	`+ $just_save_results = (!empty($user_input) && strtolower($user_input[0]) === 's');`
`946`	`946`	`}`
`947`	`947`
`948`	`948`	`if ($just_save_results \|\| !getenv('NO_INTERACTION') \|\| TRAVIS_CI) {`