Fix GH-8421: Attributes that target functions are not valid for anony…

…mous functions defined within a method

Closes GH-8424

Zend/tests/attributes/gh8421.phpt

@@ -0,0 +1,59 @@
+--TEST--
+Bug GH-8421: Attributes that target functions are not valid for anonymous functions defined within a method
+--FILE--
+<?php
+#[Attribute(Attribute::TARGET_FUNCTION)]
+class FunctionAttribute
+{
+    public int $number = 1;
+}
+
+$globalClosure = #[FunctionAttribute]
+fn() => true;
+$globalStaticClosure = #[FunctionAttribute]
+static fn() => true;
+
+class ClosureHolder
+{
+    public function getClosureDefinedInScope(): Closure
+    {
+        return #[FunctionAttribute]
+        fn() => true;
+    }
+
+    public function getStaticClosureDefinedInScope(): Closure
+    {
+        return #[FunctionAttribute]
+        static fn() => true;
+    }
+
+    public static function getClosureDefinedInScopeStatically(): Closure
+    {
+        return #[FunctionAttribute]
+        fn() => true;
+    }
+
+    public static function getStaticClosureDefinedInScopeStatically(): Closure
+    {
+        return #[FunctionAttribute]
+        static fn() => true;
+    }
+}
+
+var_dump((new ReflectionFunction($globalClosure))->getAttributes(FunctionAttribute::class)[0]->newInstance()->number);
+var_dump((new ReflectionFunction($globalStaticClosure))->getAttributes(FunctionAttribute::class)[0]->newInstance()->number);
+var_dump((new ReflectionFunction(ClosureHolder::getClosureDefinedInScopeStatically()))->getAttributes(FunctionAttribute::class)[0]->newInstance()->number);
+var_dump((new ReflectionFunction(ClosureHolder::getStaticClosureDefinedInScopeStatically()))->getAttributes(FunctionAttribute::class)[0]->newInstance()->number);
+
+$holder = new ClosureHolder;
+
+var_dump((new ReflectionFunction($holder->getClosureDefinedInScope()))->getAttributes(FunctionAttribute::class)[0]->newInstance()->number);
+var_dump((new ReflectionFunction($holder->getStaticClosureDefinedInScope()))->getAttributes(FunctionAttribute::class)[0]->newInstance()->number);
+?>
+--EXPECT--
+int(1)
+int(1)
+int(1)
+int(1)
+int(1)
+int(1)

ext/reflection/php_reflection.c

@@ -1770,7 +1770,7 @@ ZEND_METHOD(ReflectionFunctionAbstract, getAttributes)
 
 	GET_REFLECTION_OBJECT_PTR(fptr);
 
-	if (fptr->common.scope) {
+	if (fptr->common.scope && !(fptr->common.fn_flags & ZEND_ACC_CLOSURE)) {
 		target = ZEND_ATTRIBUTE_TARGET_METHOD;
 	} else {
 		target = ZEND_ATTRIBUTE_TARGET_FUNCTION;