Skip to content

Commit

Permalink
Fix EXTENSIONS for cgi tests
Browse files Browse the repository at this point in the history
The extension information needs to be fetched using the cli binary,
not the cgi binary.
  • Loading branch information
nikic committed Jun 11, 2021
1 parent 4083600 commit ea126c5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion run-tests.php
Expand Up @@ -1851,6 +1851,7 @@ function run_test(string $php, $file, array $env): string

$temp_filenames = null;
$org_file = $file;
$orig_php = $php;

if (isset($env['TEST_PHP_CGI_EXECUTABLE'])) {
$php_cgi = $env['TEST_PHP_CGI_EXECUTABLE'];
Expand Down Expand Up @@ -2064,7 +2065,7 @@ function run_test(string $php, $file, array $env): string
settings2array($ini_overwrites, $ext_params);
$ext_params = settings2params($ext_params);
$extensions = preg_split("/[\n\r]+/", trim($test->getSection('EXTENSIONS')));
[$ext_dir, $loaded] = $skipCache->getExtensions("$php $pass_options $extra_options $ext_params $no_file_cache");
[$ext_dir, $loaded] = $skipCache->getExtensions("$orig_php $pass_options $extra_options $ext_params $no_file_cache");
$ext_prefix = IS_WINDOWS ? "php_" : "";
$missing = [];
foreach ($extensions as $req_ext) {
Expand Down

0 comments on commit ea126c5

Please sign in to comment.