Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t reset func in zend_closure_internal_handler #9823

Closed
wants to merge 2 commits into from
Closed

Don’t reset func in zend_closure_internal_handler #9823

wants to merge 2 commits into from

Conversation

rioderelfte
Copy link
Contributor

The pointer is used in _zend_observe_fcall_begin().

The new test segfaulted before the change.

@rioderelfte
Don’t reset func in zend_closure_internal_handler
c0c4003 
The pointer is used in _zend_observe_fcall_begin().
@rioderelfte rioderelfte changed the base branch from master to PHP-8.2 October 24, 2022 19:50
@iluuu1994 iluuu1994 requested a review from bwoebi October 24, 2022 23:13
bwoebi
bwoebi approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, all other occurrences of EX(func) = NULL; are trampolines, but that particular one doesn't seem so. Good catch.

bwoebi pushed a commit that referenced this pull request Oct 26, 2022
@rioderelfte @bwoebi
Don’t report arginfo violations on fake closures (#9823)
b9474bf
@bwoebi
Copy link
Member

bwoebi commented Oct 26, 2022

Merged via b9474bf.

@bwoebi bwoebi closed this Oct 26, 2022
@rioderelfte rioderelfte deleted the dont-reset-func-in-closure branch October 29, 2022 09:50
@rioderelfte rioderelfte restored the dont-reset-func-in-closure branch October 29, 2022 10:07
@rioderelfte rioderelfte deleted the dont-reset-func-in-closure branch October 29, 2022 10:09
@rioderelfte rioderelfte restored the dont-reset-func-in-closure branch October 29, 2022 10:12
@rioderelfte rioderelfte mentioned this pull request Oct 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees
No one assigned
Labels
Category: Engine Extension: zend_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rioderelfte @bwoebi