Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/imap/tests/*mutf7*.phpt: update for missing utf8_to_mutf7() #11654

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

orlitzky
Copy link
Contributor

@orlitzky orlitzky commented Jul 9, 2023

Our ./configure script (ext/imap/config.m4) checks for the utf8_to_mutf7() function in the c-client library, and defines HAVE_IMAP_MUTF7 only if it exists. The two corresponding PHP functions are disabled when it does not, but their tests do not account for that. Here we add two SKIPIFs to hand that scenario.

Our ./configure script (ext/imap/config.m4) checks for the
utf8_to_mutf7() function in the c-client library, and defines
HAVE_IMAP_MUTF7 only if it exists. The two corresponding PHP
functions are disabled when it does not, but their tests do
not account for that. Here we add two SKIPIFs to hand that
scenario.
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ext/imap/tests/imap_mutf7_to_utf8.phpt Outdated Show resolved Hide resolved
ext/imap/tests/imap_utf8_to_mutf7_basic.phpt Outdated Show resolved Hide resolved
@Girgias Girgias merged commit 893ca53 into php:master Jul 10, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants