Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Descriptor creation more type-safe #2245

Open
mvriel opened this issue Feb 1, 2020 · 0 comments
Open

Make Descriptor creation more type-safe #2245

mvriel opened this issue Feb 1, 2020 · 0 comments

Comments

@mvriel
Copy link
Member

mvriel commented Feb 1, 2020

In the AssemblerInterface's create method (and thus every assembler underneath) we are unable to apply proper type-hinting. This opens the door for various type-related bugs.

To decrease the chances of these type of bugs creeping in we want to change the Descriptor creation process in such a way that a real type-hint can be used in the create function.

This is more effort than just using a type-hint; we may need to change the interfaces of some classes or even introduce a new interface or abstract class to help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
phpDoc issue triage board
  
Needs triage
Development

No branches or pull requests

2 participants