Merge branch 'carusogabriel-phpunit' into develop

phpDocumentor · Apr 29, 2018 · 181dc55 · 181dc55
2 parents 95e805e + 23060ff
commit 181dc55
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/tests/unit/phpDocumentor/Descriptor/CollectionTest.php b/tests/unit/phpDocumentor/Descriptor/CollectionTest.php
@@ -186,12 +186,12 @@ public function testClearingTheCollection()
      */
     public function testIfExistingElementsAreDetected()
     {
-        $this->assertFalse(isset($this->fixture[0]));
+        $this->assertArrayNotHasKey(0, $this->fixture);
         $this->assertFalse($this->fixture->offsetExists(0));
 
         $this->fixture[0] = 'abc';
 
-        $this->assertTrue(isset($this->fixture[0]));
+        $this->assertArrayHasKey(0, $this->fixture);
         $this->assertTrue($this->fixture->offsetExists(0));
     }
 

diff --git a/tests/unit/phpDocumentor/Plugin/Scrybe/Converter/Metadata/TableOfContentsTest.php b/tests/unit/phpDocumentor/Plugin/Scrybe/Converter/Metadata/TableOfContentsTest.php
@@ -46,7 +46,7 @@ public function testAdd()
         $this->object[] = $file;
 
         $this->assertCount(1, $this->object);
-        $this->assertTrue(isset($this->object['test']));
+        $this->assertArrayHasKey('test', $this->object);
         $this->assertSame($file, $this->object['test']);
     }
 

diff --git a/tests/unit/phpDocumentor/Transformer/Behaviour/CollectionTest.php b/tests/unit/phpDocumentor/Transformer/Behaviour/CollectionTest.php
@@ -104,7 +104,7 @@ public function testCountBehavioursInCollection()
 
         // Assert
         $this->assertCount(1, $this->fixture);
-        $this->assertSame(1, count($this->fixture));
+        $this->assertCount(1, $this->fixture);
         $this->assertSame(1, $this->fixture->count());
     }
 }
diff --git a/tests/unit/phpDocumentor/Transformer/Template/CollectionTest.php b/tests/unit/phpDocumentor/Transformer/Template/CollectionTest.php
@@ -59,7 +59,7 @@ public function testIfLoadRetrievesTemplateFromFactoryAndRegistersIt()
 
         // Assert
         $this->assertCount(1, $this->fixture);
-        $this->assertTrue(isset($this->fixture[$templateName]));
+        $this->assertArrayHasKey($templateName, $this->fixture);
         $this->assertSame($template, $this->fixture[$templateName]);
     }