Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a sniff command #1421

Closed
5 tasks
mvriel opened this issue Sep 2, 2014 · 5 comments
Closed
5 tasks

Consider adding a sniff command #1421

mvriel opened this issue Sep 2, 2014 · 5 comments

Comments

@mvriel
Copy link
Member

mvriel commented Sep 2, 2014

phpDocumentor2 has the ability to act as a PHP_DocSniffer (the documentation variant of PHP_CodeSniffer) where we detect how well your project is documented and what to improve. It might be a good thing to make this more obvious by introducing a new Sniff command that would provide the user with the ability to just scan for issues and output any error found, or output it to a checkstyle XML files.

  • Add new 'sniff' command
  • Re-use output style
  • Add same command line options from PHP_CodeSniffer
  • Add support for 'ruleset.xml' configuration files that contain standard definitions
  • Exit with exit code 1 if an error is found

Please note: in #40 we have added support for Rules and Rulesets

@mvriel
Copy link
Member Author

mvriel commented Sep 2, 2014

@ashnazg what do you think of this feature? Technically everything is already in phpDocumentor so we would only have to wrap around existing components.

@ashnazg
Copy link
Member

ashnazg commented Sep 2, 2014

Sounds fine to me. Sounds like a good way to measure, and in a way that's analogous to Codesniffer, and thus its readability is increased due to peoples' familiarity with Codesniffer.

@mvriel
Copy link
Member Author

mvriel commented Sep 3, 2014

I am in the process of updating the issue description with all necessary steps and actions

@GaryJones
Copy link

PHPCS and related packages already have some standards / sniffs that focus on DocBlocks and comments.

Would it not be better to let PHPCS sniff the code (Docs), and let phpDocumentor generate the documentation?

@jaapio
Copy link
Member

jaapio commented Jan 26, 2024

Closing, we will not address this in phpDocumentor

@jaapio jaapio closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants