Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several extensions are not listed in composer requirements #2054

Closed
dktapps opened this issue Jan 6, 2019 · 2 comments
Closed

Several extensions are not listed in composer requirements #2054

dktapps opened this issue Jan 6, 2019 · 2 comments
Milestone

Comments

@dktapps
Copy link

dktapps commented Jan 6, 2019

When installing phpDocumentor2 using Composer, everything seems to be fine until trying to run it.
My PHP build is stripped-back (built with --disable-all and only specific extensions enabled to reduce build size), and does not have several extensions that phpDocumentor expects to be present but does not declare in composer.json.

According to a PhpStorm scan of the project on the develop branch, the missing dependencies are:

  • ext-dom
  • ext-simplexml
  • ext-libxml
  • ext-xsl
  • ext-zlib

There may be other dependencies on other branches that I have not checked.

Expected Behavior

Installing phpDocumentor2 with my PHP setup should fail because ext-dom, ext-simplexml and ext-libxml are not found in my PHP build

Actual Behavior

phpDocumentor2 installs successfully and crashes when trying to run.

Steps to Reproduce the Problem

  1. Compile PHP with any of the listed XML extensions missing (simplexml is the first problem I encountered)
  2. Install phpDocumentor in a project
  3. Try to generate documentation and watch it crash.

Your environment

  • Version used: 2.9
  • Install method: composer install phpdocumentor/phpdocumentor
  • php version: 7.2.13
  • Operating system and version (e.g. Ubuntu 16.04, Windows 7): Windows 10
@jaapio jaapio added this to the 2.10.0 milestone Jan 7, 2019
@jaapio
Copy link
Member

jaapio commented Jan 7, 2019

Thanks for your report, we are working currently on a new version of phpdocumentor, which does have the listed requirements.
Due limited time we don't give this issue priority over the new version.

@mvriel
Copy link
Member

mvriel commented Jun 15, 2019

While reviewing this issue and the composer.json of v3 I noticed some of your suggestions were missing. I have resolved this for v3, because of limited resources we are not able to backport many of these improvements to v2.x. Because of this limitation, I am going to close this item as the issue is resolved in v3.

If you have more suggestions like these we would love to hear more!

@mvriel mvriel closed this as completed Jun 15, 2019
@jaapio jaapio modified the milestones: 2.10.0, 3.0.0 Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants