Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump list has intermediary, unwanted item #1213

Open
greg0ire opened this issue Feb 21, 2021 · 1 comment
Open

Jump list has intermediary, unwanted item #1213

greg0ire opened this issue Feb 21, 2021 · 1 comment

Comments

@greg0ire
Copy link
Contributor

When using :PhpactorGotoDefinition, the jump list seems to have an extra item matching the first line of the destination file. This is a bug I remember having for quite some time, never bothered reporting it until now but it does seem to be related to phpactor because using the native tags-based <C-]> does not produce that bug.

For instance, in doctrine/orm:
vi tests/Doctrine/Tests/ORM/Functional/NativeQueryTest.php
44j$bb:clearjumps<CR>:PhpactorGotoDefinition<CR><C-O>:jumps will show the issue

Peek 2021-02-21 10-35

@camilledejoye
Copy link
Contributor

Indeed this is an issue with the vim plugin, it was first fixed with #828 and #837
I think it was broke around #893

If I recall properly this extra jump is added whenever we open a file that was not already open in vim.
We need to identify when vim add this extra jump and remove it to preserve the user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants