Generic tag reported to be incompatible when correct for child generic classes

[calebdw]

Hello!

I'm experiencing a problem similar to #2262, but this time when making child classes generic:

Code Example:

<?php

namespace Phpactor;

abstract class Model
{
}

/** @template TModel of \Phpactor\Model */
class Factory
{
}

/**
 * @template TModel of \Phpactor\Schedule
 * @extends Factory<TModel>
 */
class ScheduleFactory extends Factory
{
}

class Schedule extends Model
{
}

/** @extends ScheduleFactory<ChildSchedule> */
class ChildScheduleFactory extends ScheduleFactory
{
}

class ChildSchedule extends Schedule
{
}

From PHPStan:

Thanks!

[calebdw]

@dantleech, this was fixed but started reporting again...was there a regression?

[dantleech]

the tests would indicate that it's fine:

phpactor/lib/WorseReflection/Bridge/TolerantParser/Diagnostics/DocblockMissingExtendsTagProvider.php

Lines 309 to 331 in 6f23af2

	yield new DiagnosticExample(
	title: 'extend with typed templated argument',
	source: <<<'PHP'
	<?php
	abstract class Model {}
	class Schedule extends Model {}
	/** @template TModel of Model */
	class Factory {}
	/**
	* @template TModel of Schedule
	* @extends Factory<TModel>
	*/
	class ScheduleFactory extends Factory {}
	PHP,
	valid: true,
	assertion: function (Diagnostics $diagnostics): void {
	Assert::assertCount(0, $diagnostics);
	}
	);

maybe something else changed on your side? or the test doesn't cover your case?

[calebdw]

That looks like the test for #2262, but this is a separate case. The test does not give me any issues

[calebdw]

This should produce a failing test:

<?php

namespace Phpactor;

abstract class Model {}

class Schedule extends Model {}

/** @template TModel of \Phpactor\Model */
class Factory {}

/**
 * @template TModel of Schedule
 * @extends Factory<TModel>
 */
class ScheduleFactory extends Factory {}