conditional types do not take into account default values

[calebdw]

Hello!

PHPStan supports conditional return types---it would be great if phpactor could understand this. Currently it looks like these are just typed as null

Thanks!

[dantleech]

PHpactor also supports conditional return types, have you got an example of a conditional type that doesn't work?

https://github.com/phpactor/phpactor/blob/master/lib/WorseReflection/Tests/Inference/type/conditional-type-nested.test

[calebdw]

Interesting---I have this Laraval helper function that I was trying to add a condition return type to:

if (! function_exists('logger')) {
    /**
     * Log a debug message to the logs.
     *
     * @param  string|null  $message
     * @param  array  $context
     * @return ($message is null ? \Illuminate\Log\LogManager : null)
     */
    function logger($message = null, array $context = [])
    {
        if (is_null($message)) {
            return app('log');
        }

        app('log')->debug($message, $context);

        return null;
    }
}

But the variable appears to be null:

It does seem to be picking up the return type in the docs though:

[calebdw]

Ah, this seems to work so I guess it's just not recognizing the absence as a null value:

[dantleech]

thanks, updated title and added the bug label