Release 14 by February 1st

[dantleech]

There are quite some changes in develop currently, and some of them are problematic and blocking the next release:

• Import all classes: does not work properly [develop] Import all classes requires work before next release #864 => Only import unique names (class import all) #870
• Goto Implementation(s): Unusably slow in large projects and opinionated (depends on naming conventions to filter)
• The async FZF list implementation breaks the callback system of the menu - there is currently a dirty hack to work around this. edit: Have made this functionality experimental.
• Infer PHP version from Composer if possible? #872 Fallback to PHP version in composer.json if possible.

We should consider reverting the above if they cannot be fixed.

In addition it would be great to:

• Finish the generated code sanitising work here
• Finish support for nullable types
• Merge support for PHP version specific templates
• Preserve original path if available when generating new class #796

Anything else I'm missing? cc @elythyr @Einenlum

[camilledejoye]

For the "goto implementation" I think it's OK to include it in the release as long as it's well documented that the feature is slow on large project.
I often use ripgrep instead but in some cases I'm willing to take a few minutes to have a better result with this feature.
As long as it doesn't break anything, the user can choose to not use it so it's OK for me.

For the FZF list, I will try to get a look at it, we might have to change a few things or at least not use it for features that returns a list of actions.

[dantleech]

I have a pretty good solution for goto implementation - using a lazy index. However I'm currently blocked with the "cs fixer" implementation in code-builder - as it really doesn't work very well. I may well revert that completely and just live with the existing poorly formatted code.

[camilledejoye]

I think it's acceptable, the "poorly formated code" was only in some really specific cases if I remember properly.

[camilledejoye]

Do you think it would be possible to use the monolith for the next release ?

[dantleech]

I don't think so - it's very time consuming to setup and I haven't got confidence in any particular plan. I'd rather not add further tasks to the list.

[dantleech]

The CS fixer (for generated code) has been completely removed now. Will hopefully get the indexer finished tomorrow.

[dantleech]

@elythyr I made a PR to make the FZF / BAT features experimental for this release: #883

[dantleech]

Hae added PHP version detection which also checks composer and improved the workspace-query indexer to support a basic --watch mode.

In addition to enabling goto implementation the workspace-query module also proides source code location - which will provide much better support for non-composer / strange projects / projects which break autoloaders.

It's still experimental though, the indexer is polling currently which means scanning potentially ~30k files every x seconds - it should at least support using inotify on Linux-like machines. In addition the VIM plugin should be able to manage the process and keep it running - and that's interesting as VIM and Nvim have different APIs. Probably better to delegate to a third-party plugin if available.

Would also to allow the use of > 1 core when using the indexer...

So potentially will keep workspace-query experimental.

[camilledejoye]

It's indeed to possible to find third-party plugin to deal with async in both Vim and NVim.

[dantleech]

Well, it's fairly trivial to do it ourselves (and stay dependency-less) I think (this is the WIP)

[dantleech]

One month late: https://www.dantleech.com/blog/2020/03/01/phpactor-14/

... and there was much rejoicing 🎉