Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid language definition in QueryManagerTest::testGetQuery #38

Closed
bergie opened this issue Nov 21, 2011 · 0 comments
Closed

Invalid language definition in QueryManagerTest::testGetQuery #38

bergie opened this issue Nov 21, 2011 · 0 comments

Comments

@bergie
Copy link
Contributor

bergie commented Nov 21, 2011

The query node in fixtures/general/query.xml has the wrong value for jcr:language. The spec says:

jcr:language holds the string returned by Query.getLanguage().

...which should be the appropriate constant from \PHPCR\Query\QueryInterface::

So:

<sv:property sv:name="jcr:language" sv:type="String">
  <sv:value>sql2</sv:value>
</sv:property>

Should be:

<sv:property sv:name="jcr:language" sv:type="String">
  <sv:value>JCR-SQL2</sv:value>
</sv:property>

In Midgard PHPCR tests this causes:

4) PHPCR\Tests\Query\QueryManagerTest::testGetQuery PHPCR\Query\InvalidQueryException: Unsupported 'sql2' language

/home/bergie/Projects/phpcr-midgard2/src/Midgard/PHPCR/Query/QueryManager.php:24
/home/bergie/Projects/phpcr-midgard2/src/Midgard/PHPCR/Query/QueryManager.php:62
/home/bergie/Projects/phpcr-midgard2/api-test/suite/tests/06_Query/QueryManagerTest.php:37
@dbu dbu closed this as completed in e07d7b7 Nov 28, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants