add unit tests for Sql2ToQomQueryConverter

[lsmith77]

No description provided.

[dbu]

@dantleech i noticed that in phpcr-utils, there is a bunch of open tickets about the PHPCR query builder. would be great if you could have a look through them and comment on those you think are now fixed.

[dantleech]

The issues in phpcr-utils seem to be related to the Sql2QomConverter and
other SQL stuff, I don't think I have fixed any of them (knowingly),
although I suspect #3 works now.

On Sat, Jan 12, 2013 at 12:27:02AM -0800, David Buchmann wrote:

@dantleech i noticed that in phpcr-utils, there is a bunch of open tickets
about the PHPCR query builder. would be great if you could have a look through
them and comment on those you think are now fixed.

—
Reply to this email directly or view it on GitHub.

[dbu]

we have lots of functional tests in phpcr-api-tests that test the query converter. do we still need unit tests?

[lsmith77]

i think it would be nice to have some basic tests if just for during development .. however in reality we will always test things with the functional tests. so its not critical imho.