Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty confval value should output a warning #983

Closed
brotkrueml opened this issue Apr 15, 2024 · 0 comments · Fixed by #988
Closed

Empty confval value should output a warning #983

brotkrueml opened this issue Apr 15, 2024 · 0 comments · Fixed by #988
Assignees
@linawolf
Labels
feature triage

Comments

@brotkrueml
Copy link
Contributor

Feature request

When an empty confval is given, like:

.. confval::
   :name: some-name

then a warning should be outputted when rendering. This is mostly a mistake as an empty confval does not make sense and the user should be hinted about that.
@brotkrueml brotkrueml mentioned this issue Apr 15, 2024
Merged
@linawolf linawolf self-assigned this Apr 15, 2024
linawolf added a commit that referenced this issue Apr 18, 2024
@linawolf
[BUGFIX] Warn when a directive has not title
283a9eb 
resolves #983
@linawolf linawolf mentioned this issue Apr 18, 2024
Merged
linawolf added a commit that referenced this issue Apr 18, 2024
@linawolf
[BUGFIX] Warn when a directive has not title
08a9c91 
resolves #983
phpdoc-bot pushed a commit that referenced this issue Apr 18, 2024
@linawolf
[BUGFIX] Warn when a directive has not title
f880b29 
resolves #983

(cherry picked from commit 08a9c91)
phpdoc-bot pushed a commit to phpDocumentor/guides-restructured-text that referenced this issue Apr 18, 2024
@linawolf
[BUGFIX] Warn when a directive has not title
a157fb7 
resolves phpDocumentor/guides#983
phpdoc-bot pushed a commit to phpDocumentor/guides-restructured-text that referenced this issue Apr 18, 2024
@linawolf
[BUGFIX] Warn when a directive has not title
53d6967 
resolves phpDocumentor/guides#983

(cherry picked from commit 08a9c919b0190fa3610280c160db959e6e4aeda7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linawolf linawolf

Labels
feature triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Warn when a directive has not title phpDocumentor/guides
2 participants
@brotkrueml @linawolf