Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curve25519 and curve448 support #117

Closed
Spomky opened this issue Jan 24, 2016 · 7 comments
Closed

curve25519 and curve448 support #117

Spomky opened this issue Jan 24, 2016 · 7 comments

Comments

@Spomky
Copy link
Contributor

Spomky commented Jan 24, 2016

The RFC7748 introduces two new curves: curve25519 and curve448.

Do you plan to add a support for these two curves?

@afk11
Copy link
Member

afk11 commented Jan 25, 2016

They would be nice, we'd have to check the algorithm is suitable. It might be more effort than adding it to the CurveFactory, but worthwhile all the same.

@Spomky
Copy link
Contributor Author

Spomky commented Feb 6, 2016

Great news.
I found these repositories that provide Ed25519 implementations. That could help you.

@afk11
Copy link
Member

afk11 commented Feb 6, 2016

Interesting, I'll give that a look! I read over the RFC the other day, it seems to have lots of details not seen in PHPECC today. It wouldn't be as straightforward as I would have hoped!

The extension is probably faster than we'll be able to pull off in pure PHP, but I'll have to check it later!

@Spomky
Copy link
Contributor Author

Spomky commented Mar 4, 2016

Well... yes you are right, this library will never be as fast as an extension.
I decided to try the extension mentioned above and the first tests that I ran gave me good results.

@paragonie-scott
Copy link
Contributor

I've implemented X25519 and Ed25519 in sodium_compat if you'd like to either reference that implementation (or just add sodium_compat as a dependency).

Take note that it has yet to be audited and therefore should be viewed as experimental until we can get that done.

@paragonie-scott
Copy link
Contributor

We've tagged v1 so it may be worth adopting sodium_compat to fulfill your needs for Curve25519.

@Spomky
Copy link
Contributor Author

Spomky commented May 29, 2018

Closing as the curves Ed25519/X25519 are available by other means (libCrypto or PHP 7.2).
An implementation of the curves Ed448 and X448 is still missing, but it looks like these curves are not widely used.

@Spomky Spomky closed this as completed May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants