Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be way more cautious about overwriting existing files. #3

Open
beporter opened this issue Feb 12, 2015 · 0 comments
Open

Be way more cautious about overwriting existing files. #3

beporter opened this issue Feb 12, 2015 · 0 comments

Comments

@beporter
Copy link
Contributor

The installer is currently extremely unceremonious about overwriting any existing files in a consuming project. If you have your own Vagrantfile in your project root, and you composer require loadsys/puphpet-release, that file will get overwritten without notice.

This is, Bad™, in no uncertain terms. We should attempt to detect existing files on our FIRST installation only, and abort (or prompt) if they are already present.

As an important distinction; on subsequent installs (during composer updates) it should be safer to assume that /Vagrantfile and /puphpet/ are now under "our" control, and can be updated immediately.

This ties into how we want to handle PuPHPet's files/ and exec-*/startup-* folders though, since currently there is no mechanism for integrating those from the consuming project into the "installed" /puphpet folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant