Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress indicator #94

Open
Dynom opened this issue Jul 26, 2013 · 26 comments
Open

Progress indicator #94

Dynom opened this issue Jul 26, 2013 · 26 comments

Comments

@Dynom
Copy link

Dynom commented Jul 26, 2013

The closest I came was issue #37 but I'm unsure if that request is identical to this one.

We run PHPMD frequently (it's part of a pre-push hook) but it's very inconvenient that no progress, at all, is shown by PHPMD. We'll settle for anything as trivial as e.g. an output like PHPUnit (just a dot per test) or fancy, a 0-100% indicator but either way. Some form of progress-feedback is highly appreciated.

@Chowarmaan
Copy link

+1. Even similar output to PHP_CodeSniffer (dot, E for error, etc...) would be good. This will help to see the tool is still processing as well.

@buskamuza
Copy link

+1. It will also help to run phpmd tests on Travis CI. Now Travis just stops the build after 10 min of waiting :(

@schmittjoh
Copy link

@buskamuza, you might want to try https://scrutinizer-ci.com for code analysis (disclaimer: I work there).

@localheinz
Copy link

👍

I'd love to see this implemented.

@gunnarlium
Copy link

+1

@ravage84
Copy link
Member

ravage84 commented Oct 8, 2014

💯 oh yesss 👍

@JeroenDeDauw
Copy link
Contributor

+1 to progress reporting. Has any work on this been done? Looks like b94cb21 incorrectly referenced this issue

@atulatri
Copy link

+1

@fezfez
Copy link

fezfez commented Jun 5, 2015

+1

2 similar comments
@schmengler
Copy link

+1

@QuentinCurtet
Copy link

+1

@ravage84 ravage84 modified the milestone: 2.4.0 Nov 7, 2015
@keradus
Copy link
Contributor

keradus commented Jan 27, 2016

👍

@ravage84 ravage84 modified the milestones: 2.4.0, 2.5.0 Mar 8, 2016
@tabishjaved03
Copy link

+1

@ravage84 ravage84 modified the milestones: 2.5.0, 2.6.0 Jun 28, 2016
@josephdpurcell
Copy link

+1

@alfredbez
Copy link

Please use GitHub Reactions

@josephdpurcell
Copy link

I think #37 would be an acceptable way to show progress.

To me, a lack of logging/debug reporting is itself a bug. PHPMD is an important part of the PHP software community, and if something goes wrong and there's no error/indication what is going on, you cannot use PHPMD. I just ran PHPMD and after 104 mins I still have no sign of life from PHPMD.

I am working on debugging PHPMD timeouts on Code Climate, see codeclimate/codeclimate-phpmd#30 feature would be very helpful!

@PierreRambaud
Copy link

+1

@ravage84 ravage84 removed this from the 2.6.0 milestone Jan 30, 2017
@mikepmtl
Copy link

Part of our Jenkins build process. No idea if it is running or not. Even just a "." would be nice.
Thank you.

@orlangur
Copy link

I just ran PHPMD and after 104 mins I still have no sign of life from PHPMD.

I don't think this is a valid use case :) The problem here is that some project-wide inspections are waaay too slow. Maybe 10 minutes is too strict for build to complete but it should not take hours.

Is PHPMD currently optimal in terms of computational complexity? Some O(N*N) where N is lines of code in project?`

@akielbasa
Copy link

i found an issue with user rights on windows domains, this might lead to an issue with phpmd beeing super slow

correcting the speed on my mashine from 20minute precommit
to 20 second precommit

the case is:

while using phpstorm (but for console its the same)
having the project outside your user directory

starting phpstorm / cmd as admin (yes you NEED to be lokal admin for this)
fixing the issue

i was able to see this issue on a lot of pc's in our company

i know this has nothing to do with the progressbar which would be a blast,
but most people complain that php md is actually too slow raising up to 104 minutes of precommits,

if this is your case, you might not have this issue in the future anymore

tl;dr

if you have this scenario:
your project ist not in your userfolder
try running console / phpstorm as admin (local admin rights needed when in domain)
see if the time is better

on our case
20 minutes => 12~ seconds

@ravage84 ravage84 modified the milestones: 2.7.0, 2.8.0 Jul 9, 2019
@kylekatarnls kylekatarnls modified the milestones: 2.8.0, 2.9.0 Oct 19, 2019
@InvisibleSmiley
Copy link

i found an issue with user rights on windows domains, this might lead to an issue with phpmd beeing super slow

Thanks for the pointer, I had the same problem! Further investigation showed that this is actually a PHP Depend issue. Filed pdepend/pdepend#447

Workaround: Copy https://github.com/pdepend/pdepend/blob/master/pdepend.xml.dist to the root of your project, optionally naming it either pdepend.xml

@tebeso
Copy link

tebeso commented Nov 27, 2020

i can confirm that running phpmd on windows is super slow (15 seconds for one file) and when i run as admin, its 44ms. Please fix this.

@kylekatarnls
Copy link
Member

This is not happening on every Windows machine. It's happening on particular settings having HOME set on a slow file system/slow network. It's not actually PHPMD / PDepend being slow, but HOME read/write, you can solve it by setting a custom HOME (to some directory with a faster access) when running the command.

@tebeso
Copy link

tebeso commented Nov 27, 2020

This is not happening on every Windows machine. It's happening on particular settings having HOME set on a slow file system/slow network. It's not actually PHPMD / PDepend being slow, but HOME read/write, you can solve it by setting a custom HOME (to some directory with a faster access) when running the command.

and how do i do that?

@kylekatarnls
Copy link
Member

set HOME=C:\Path\To\A\Fast\Directory
phpmd src text phpmd.xml

@prestamod
Copy link

set HOME=C:\Path\To\A\Fast\Directory
I love you

@kylekatarnls kylekatarnls modified the milestones: 2.10.0, 2.11.0 Apr 11, 2021
@kylekatarnls kylekatarnls modified the milestones: 2.11.0, 2.12.0 Nov 27, 2021
@kylekatarnls kylekatarnls modified the milestones: 2.12.0, 2.13.0 Jun 19, 2022
@kylekatarnls kylekatarnls modified the milestones: 2.13.0, 2.14.0 Sep 10, 2022
@kylekatarnls kylekatarnls modified the milestones: 2.14.0, 2.15.0 Sep 27, 2023
@kylekatarnls kylekatarnls modified the milestones: 2.15.0, 2.16.0 Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests