Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Default Ruleset #99

Closed
fonsecas72 opened this issue Feb 21, 2015 · 3 comments
Closed

A Default Ruleset #99

fonsecas72 opened this issue Feb 21, 2015 · 3 comments

Comments

@fonsecas72
Copy link
Contributor

When I use a config file I have to set every single ruleset in my config for this tool to work properly.

Doing this causes me some trouble:

  • I don't know which values to use
  • I don't know each ruleset's name

At RuleSet class __contructor we have an array that suggests a default list of ruleset and I can use that to config the yml properly.

Obviously, this is not something as easy as it should be.
Perhaps this ruleset list should in fact be a default list and then we would merge this at the __contructor.

This seems obvious to me but as there are tests that will fail, I rather ask you first instead of PR right away.

@Halleck45
Copy link
Collaborator

Yes, ruleset definition could be injected with another object / config file, in order to centralize definitions and reuse them everywhere.

@Halleck45
Copy link
Collaborator

@fonsecas72 what do you think about #207 ?

@Halleck45
Copy link
Collaborator

Fixed by #207 . I close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants