Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 5.3 compatibility] Multiple interfaces implementation #7

Closed
tipyy opened this issue Feb 25, 2014 · 2 comments
Closed

[PHP 5.3 compatibility] Multiple interfaces implementation #7

tipyy opened this issue Feb 25, 2014 · 2 comments
Labels

Comments

@tipyy
Copy link

tipyy commented Feb 25, 2014

I've got this error running metrics.phar on 5.3.3 (CentOs 6.5) :

PHP Fatal error:  Can't inherit abstract function Hal\Bounds\BoundsAgregateInterface::calculate() (previously declared abstract in Hal\Bounds\BoundsInterface)
...

It seems that under php 5.3.9, a class couldn't implement 2 interfaces with a same named method.

I've commented the second implementation and modified Hal/Formater/Summary classes and Hal/Command/Job/SearchBounds to make it work but I'm not sure its a good solution.

@Halleck45
Copy link
Collaborator

Fixed for me in wheezy64 with PHP 5.3.3

Thank's for the report

@tipyy
Copy link
Author

tipyy commented Feb 28, 2014

Fixed for me too.
Thank's a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants