Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing optional dependencies: #70

Closed
nijel opened this issue Sep 27, 2016 · 2 comments
Closed

Missing optional dependencies: #70

nijel opened this issue Sep 27, 2016 · 2 comments
Assignees

Comments

@nijel
Copy link
Contributor

nijel commented Sep 27, 2016

The detectPow function at:
https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/Util.php#L38
will use bcpow or gmp_pow or pow functions, the bcpow & gmp_pow functions require:
php5-bcmath
php5-gmp
packages

fix:
1. in docker, add php5-bcmath:
https://github.com/phpmyadmin/docker/blob/master/Dockerfile#L4
2. in debian, add under "Recommends" a PHP bcmath package:
https://sources.debian.net/src/phpmyadmin/4:4.6.4%2Bdfsg1-1/debian/control/?hl=29#L29

Reported by Emanuel Bronshtein.

@nijel
Copy link
Contributor Author

nijel commented Sep 27, 2016

I've looked at all Util::pow use cases and I don't think we're having any benefit when using bcmath or gmp functions here, so adding this dependency has IMHO no reason.

See also phpmyadmin/phpmyadmin#12595, where I propose to remove this code altogether.

@nijel nijel self-assigned this Sep 27, 2016
@nijel
Copy link
Contributor Author

nijel commented Oct 18, 2016

Code has been removed, so there is no need for these dependencies.

@nijel nijel closed this as completed Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant