Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Redirect to HTTPS from HTTP #32

Closed
7 tasks done
madhuracj opened this issue Oct 15, 2016 · 6 comments
Closed
7 tasks done

Missing Redirect to HTTPS from HTTP #32

madhuracj opened this issue Oct 15, 2016 · 6 comments
Assignees

Comments

@madhuracj
Copy link
Contributor

madhuracj commented Oct 15, 2016

As report by Emanuel Bronshtein,

visiting over HTTP the following websites will not redirect to HTTPS:

@nijel nijel self-assigned this Oct 17, 2016
@nijel
Copy link
Contributor

nijel commented Oct 17, 2016

  • For reports this is intentional setup to allow old clients to submit data.
  • For hooks we first needs to check if we're not using http URL somewhere.
  • For develdocs it's something what needs to be done at the CDN side (same issue is for www.phpmyadmin.net).

@nijel
Copy link
Contributor

nijel commented Oct 17, 2016

I've reviewed all hooks on GitHub and switched them to https, so hopefully we're safe to fully switch to https there.

@nijel
Copy link
Contributor

nijel commented Oct 17, 2016

I've just changed CDN setup on all hosts to make it consistent:

  • Redirect to HTTPS
  • Use letsencrypt certificates
  • Use HTTPS for backend connection

@nijel nijel closed this as completed Oct 17, 2016
@emanuelb
Copy link

For reports consider a redirect that black-list submit end-points (will redirect to HTTPS if the request-uri isn't /incidents/create) or redirect on non POST requests (as submissions done over POST)

@nijel
Copy link
Contributor

nijel commented Oct 25, 2016

Thats indeed an option, thanks for suggestion!

@nijel nijel reopened this Oct 25, 2016
@nijel
Copy link
Contributor

nijel commented Nov 24, 2016

Now done for reports as well.

@nijel nijel closed this as completed Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants