Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODP writer is locale sensitive in the wrong places #21

Closed
potofcoffee opened this issue May 3, 2014 · 5 comments
Closed

ODP writer is locale sensitive in the wrong places #21

potofcoffee opened this issue May 3, 2014 · 5 comments
Assignees
@Progi1984
Labels
Component - ODP Type - Bug
Milestone
0.2.0

Comments

@potofcoffee
Copy link
Contributor

On locales with a decimal mark different from the dot, the ODP writer will produce invalid documents, because page dimensions in styles.xml will contain invalid characters.

E.g., on a German (de_DE) locale, where the decimal mark is the comma, the fo:page-width attribute in style:page-layout-properties will be "25,4cm" instead of "25.4cm." The result is a broken file.

A temporary workaround is to manually set the locale to something like en_US before writing the file.
potofcoffee added a commit to VolksmissionFreudenstadt/announcement that referenced this issue May 3, 2014
@potofcoffee
Added .odp writing back
8135666 
.odp writing now works, using a workaround for the following issue:
PHPOffice/PHPPresentation#21

As of now, the presentation gets written to both a .pptx and a .odp
file.
@Progi1984 Progi1984 added this to the 0.2.0 milestone May 16, 2014
@Progi1984 Progi1984 self-assigned this Jun 18, 2014
@Progi1984
Copy link
Member

@todo :

Shared\String\number_format with options ',' & '' as final options.

Progi1984 added a commit that referenced this issue Jul 8, 2014
@Progi1984
#21 : ODP writer is locale sensitive in the wrong places
6044680
@Progi1984
Copy link
Member

@potofcoffee I have pushed a fix on the develop branch. Could you test it and give us your feedback, please ?

Progi1984 added a commit that referenced this issue Jul 8, 2014
@Progi1984
#21 : Fix PHPCS errors
6385c5a
@Progi1984
Copy link
Member

@potofcoffee Some news ?

@potofcoffee
Copy link
Contributor Author

Looks good to me.

-------- Original-Nachricht --------
Betreff: Re: [PHPPowerPoint] ODP writer is locale sensitive in the
wrong places (#21)
Datum: Montag, 21.07.2014 13:52 +0200
Von: Progi1984 notifications@github.com
An: PHPOffice/PHPPowerPoint PHPPowerPoint@noreply.github.com
Kopie (CC): Christoph Fischer

@potofcoffee https://github.com/potofcoffee Some news ?

—
Reply to this email directly or view it on GitHub
#21 (comment).

@Progi1984
Copy link
Member

@potofcoffee Thanks for your feedback. I close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Progi1984 Progi1984

Labels
Component - ODP Type - Bug
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@Progi1984 @potofcoffee