Fix incrby/decrby for large integers

phpredis · Jul 1, 2016 · 3a12758 · 3a12758
1 parent 9df734a
commit 3a12758
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 18 deletions.
diff --git a/redis_commands.c b/redis_commands.c
@@ -1382,13 +1382,13 @@ redis_atomic_increment(INTERNAL_FUNCTION_PARAMETERS, int type,
         if (val == 1) {
            *cmd_len = redis_cmd_format_static(cmd,"INCR","s",key,key_len);
         } else {
-           *cmd_len = redis_cmd_format_static(cmd,"INCRBY","sd",key,key_len,val);
+           *cmd_len = redis_cmd_format_static(cmd,"INCRBY","sl",key,key_len,val);
         }
     } else {
         if (val == 1) {
             *cmd_len = redis_cmd_format_static(cmd,"DECR","s",key,key_len);
         } else {
-            *cmd_len = redis_cmd_format_static(cmd,"DECRBY","sd",key,key_len,val);
+            *cmd_len = redis_cmd_format_static(cmd,"DECRBY","sl",key,key_len,val);
         }
     }
 

diff --git a/tests/RedisTest.php b/tests/RedisTest.php
@@ -480,32 +480,35 @@ public function testIncr()
         $this->redis->set('key', 0);
 
         $this->redis->incr('key');
-    $this->assertEquals(1, (int)$this->redis->get('key'));
+        $this->assertEquals(1, (int)$this->redis->get('key'));
 
         $this->redis->incr('key');
-    $this->assertEquals(2, (int)$this->redis->get('key'));
+        $this->assertEquals(2, (int)$this->redis->get('key'));
 
-    $this->redis->incrBy('key', 3);
-    $this->assertEquals(5, (int)$this->redis->get('key'));
+        $this->redis->incrBy('key', 3);
+        $this->assertEquals(5, (int)$this->redis->get('key'));
 
-    $this->redis->incrBy('key', 1);
-    $this->assertEquals(6, (int)$this->redis->get('key'));
+        $this->redis->incrBy('key', 1);
+        $this->assertEquals(6, (int)$this->redis->get('key'));
 
-    $this->redis->incrBy('key', -1);
-    $this->assertEquals(5, (int)$this->redis->get('key'));
+        $this->redis->incrBy('key', -1);
+        $this->assertEquals(5, (int)$this->redis->get('key'));
 
-    $this->redis->incr('key', 5);
-    $this->assertEquals(10, (int)$this->redis->get('key'));
+        $this->redis->incr('key', 5);
+        $this->assertEquals(10, (int)$this->redis->get('key'));
 
-    $this->redis->del('key');
+        $this->redis->del('key');
+
+        $this->redis->set('key', 'abc');
 
-    $this->redis->set('key', 'abc');
+        $this->redis->incr('key');
+        $this->assertTrue("abc" === $this->redis->get('key'));
 
-    $this->redis->incr('key');
-    $this->assertTrue("abc" === $this->redis->get('key'));
+        $this->redis->incr('key');
+        $this->assertTrue("abc" === $this->redis->get('key'));
 
-    $this->redis->incr('key');
-    $this->assertTrue("abc" === $this->redis->get('key'));
+        $this->redis->set('key', 0);
+        $this->assertEquals(2147483648, $this->redis->incrby('key', 2147483648));
     }
 
     public function testIncrByFloat()