Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis::mGet() & co. should be declared as variadic #1092

Closed
nicolas-grekas opened this issue Jan 17, 2017 · 2 comments
Closed

Redis::mGet() & co. should be declared as variadic #1092

nicolas-grekas opened this issue Jan 17, 2017 · 2 comments
Milestone

Comments

@nicolas-grekas
Copy link
Contributor

On PHP >5.6,

php > $r = new ReflectionMethod('Redis', 'mget');
php > var_dump($r->isVariadic());
bool(false)

This should return true.

@michael-grunder michael-grunder added this to the 3.2.0 milestone Jan 17, 2017
@michael-grunder
Copy link
Member

I'm not totally clear on how this works in the Zend api but I think it has to do with how arguments are defined. Because phpredis has so many methods it's not a small project.

Good news is that a lot of functions are generic so it is doable. We'll look at it for the next release.

@yatsukhnenko
Copy link
Member

#1055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants